Matthias Clasen [Mon, 20 Apr 2020 21:20:57 +0000 (21:20 +0000)]
Merge branch 'container-focus-cleanup' into 'master'
Strip down GtkContainer
See merge request GNOME/gtk!1722
Matthias Clasen [Sun, 19 Apr 2020 15:43:57 +0000 (11:43 -0400)]
Move the idle sizer to GtkWindow
This was only living in gtkcontainer.c for historic
reasons. Move it closer to where it belongs, and
rename it from 'idle' to 'layout', since it is
really about the layout phase of the frame clock,
nowadays.
Matthias Clasen [Sun, 19 Apr 2020 15:23:39 +0000 (11:23 -0400)]
container: Cosmetic doc cleanup
Remove remnants of child properties from the
documentation. They no longer exist.
Matthias Clasen [Sun, 19 Apr 2020 15:18:02 +0000 (11:18 -0400)]
Move set_focus_child to GtkWidget
Move the set_focus_child vfunc from GtkContainer
to GtkWidget. This removes the last focus functionality
from GtkContainer.
Update the two users.
Matthias Clasen [Mon, 20 Apr 2020 20:29:30 +0000 (16:29 -0400)]
NEWS: More updates
Matthias Clasen [Mon, 20 Apr 2020 19:01:55 +0000 (19:01 +0000)]
Merge branch 'wip/carlosg/grabbing-popovers' into 'master'
gtkpopover: Set GTK grab on autohide popovers
Closes #2446
See merge request GNOME/gtk!1729
Carlos Garnacho [Mon, 20 Apr 2020 17:48:10 +0000 (19:48 +0200)]
gtkpopover: Set GTK grab on autohide popovers
These popovers handle clicks outside the widget, and expect input
to be routed through it when it is shown. This pretty much matches
the characteristics of GTK grabs, and setting one up will ensure
the cancellation of event controllers that were active at the time
of showing the popover.
Closes: https://gitlab.gnome.org/GNOME/gtk/-/issues/2446
Matthias Clasen [Mon, 20 Apr 2020 05:33:02 +0000 (05:33 +0000)]
Merge branch 'docs-work' into 'master'
Docs work
See merge request GNOME/gtk!1727
Matthias Clasen [Mon, 20 Apr 2020 02:50:35 +0000 (22:50 -0400)]
Assorted documentation fixes
Matthias Clasen [Mon, 20 Apr 2020 02:55:30 +0000 (22:55 -0400)]
widget: Remove some leftovers
gtk_widget_can_activate_accel is gone, so remove the
vfunc and declaration.
Matthias Clasen [Sun, 19 Apr 2020 23:15:28 +0000 (23:15 +0000)]
Merge branch 'BUG_regression_select_folder_GTK4' into 'master'
GtkFileChooserWidget: fix refactor regression
Closes #2635
See merge request GNOME/gtk!1726
Nelson Benítez León [Sun, 19 Apr 2020 22:00:37 +0000 (18:00 -0400)]
GtkFileChooserWidget: fix refactor regression
Commit
4a3742979dc which removed
GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER slipped
a bad g_assert() refactoring, which is causing
a crash when selecting a folder in a GtkFileChooserButton
dialog.
Fixes #2635
Matthias Clasen [Sun, 19 Apr 2020 20:26:25 +0000 (16:26 -0400)]
Docs: Various tweaks
Tweak the docs for library initialization, versioning
and settings, and remove some outdated information.
Matthias Clasen [Sun, 19 Apr 2020 19:41:51 +0000 (15:41 -0400)]
Add GtkShortcutLabel to the docs
Matthias Clasen [Sun, 19 Apr 2020 17:29:16 +0000 (13:29 -0400)]
Add GtkCenterLayout to the docs
Matthias Clasen [Sun, 19 Apr 2020 17:15:05 +0000 (13:15 -0400)]
docs: Restructure a bit
Split the overview sections off into its own "concepts part.
Matthias Clasen [Sun, 19 Apr 2020 16:40:03 +0000 (16:40 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Remove GdkGeometry from public API
See merge request GNOME/gtk!1720
Matthias Clasen [Sun, 19 Apr 2020 02:58:07 +0000 (22:58 -0400)]
Some minor documentation fixes
Matthias Clasen [Sun, 19 Apr 2020 02:48:02 +0000 (22:48 -0400)]
Remove GdkGeometry from public API
The api to configure surfaces is now GdkToplevelLayout
and GdkPopupLayout. Unfortunately, there's still quite
a bit of internal use of GdkGeometry that will take some
time to clean up, so move it go gdkinternals.h for now.
Matthias Clasen [Sun, 19 Apr 2020 02:48:02 +0000 (22:48 -0400)]
Remove GdkGeometry from public API
The api to configure surfaces is now GdkToplevelLayout
and GdkPopupLayout. Unfortunately, there's still quite
a bit of internal use of GdkGeometry that will take some
time to clean up, so move it go gdkinternals.h for now.
Timm Bäder [Sun, 19 Apr 2020 13:11:13 +0000 (13:11 +0000)]
Merge branch 'fix-infobar-styling' into 'master'
Adwaita: Fix and simplify infobar styling
See merge request GNOME/gtk!1711
nana-4 [Sat, 18 Apr 2020 06:14:53 +0000 (15:14 +0900)]
Adwaita: Fix and simplify infobar styling
- Apply sizing regardless of style class.
- Fix bottom border not reaching the bottom corners.
- Remove unnecessary style overrides that should have been removed
during the redesign.
Timm Bäder [Sun, 19 Apr 2020 08:37:15 +0000 (08:37 +0000)]
Merge branch 'theme-link-styling-fixes' into 'master'
Adwaita: Fix link styling
See merge request GNOME/gtk!1721
nana-4 [Sun, 19 Apr 2020 06:21:40 +0000 (15:21 +0900)]
Adwaita: Fix link styling
- Fix broken visited link styling by avoiding invalid selector
`:link:visited` - CSS :link and :visited are mutually exclusive.
- In link button, move %link from the child label to the parent button,
so that the hover/active effect is applied within the whole button and
the visited style is applied correctly.
- Remove invalid selectors `:backdrop:backdrop`.
Matthias Clasen [Sun, 19 Apr 2020 02:00:26 +0000 (02:00 +0000)]
Merge branch 'fix-css-filter-transitions' into 'master'
css: Allow transitioning between different units again
See merge request GNOME/gtk!1719
Matthias Clasen [Sun, 19 Apr 2020 01:10:32 +0000 (21:10 -0400)]
css: Allow transitioning between different units again
This turns out to be necessary for transitioning filters,
and we run into criticals if transitioning numbers
unexpectedly returns NULL. I've observed that with
* {
filter: invert(80%);
}
This was broken in
c9e972eecb3a78ea.
Matthias Clasen [Sat, 18 Apr 2020 22:52:15 +0000 (22:52 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
css: Give none singletons unique names
See merge request GNOME/gtk!1718
Matthias Clasen [Sat, 18 Apr 2020 22:33:52 +0000 (22:33 +0000)]
Merge branch 'wip/fix-multi-popup-hide' into 'master'
Fix autohiding popup chain
See merge request GNOME/gtk!1717
Matthias Clasen [Sat, 18 Apr 2020 21:29:13 +0000 (17:29 -0400)]
statusbar: Don't use a frame
This frame serves no purpose anymore, and now that frames
draw frames, it shows up annoyingly.
Matthias Clasen [Sat, 18 Apr 2020 20:59:50 +0000 (20:59 +0000)]
Merge branch 'focus-adjustment' into 'master'
Drop container focus adjustments
See merge request GNOME/gtk!1716
Jonas Ådahl [Sat, 18 Apr 2020 20:51:21 +0000 (22:51 +0200)]
wayland: Don't continue showing if xdg_popup creation failed
We don't create a grabbing popup if it's not the top most one, as that
is a protocol violation, and complain if anything attempts to do it.
What we didn't do is handle this gracefully in the code that tries to
create said popup.
Fix this by dropping the attempt to show the popup on the floor, instead
of setting various state making it look like it succeeded. This won't
actually fix anything, but it'll result in a bit more accurate warnings
logged, as the state more correctly corresponds to the reality.
Jonas Ådahl [Sat, 18 Apr 2020 20:33:52 +0000 (22:33 +0200)]
surface: Hide chained autohiding popups together
When we autohide a popup surface with a grab, hide all other auto hiding
popups up the popup chain. The end result is that when you click outside
a menu with submenus open, the whole menu chain is dismissed.
Jonas Ådahl [Sat, 18 Apr 2020 20:33:29 +0000 (22:33 +0200)]
popover: Fix indentation
Matthias Clasen [Sat, 18 Apr 2020 19:51:29 +0000 (19:51 +0000)]
Merge branch 'BUG_sibebarplaces_avoid_click_focus_GTK4' into 'master'
GtkPlacesSidebar: avoid location clicks to grab focus
See merge request GNOME/gtk!1715
Matthias Clasen [Sat, 18 Apr 2020 19:24:13 +0000 (15:24 -0400)]
css: Give none singletons unique names
This makes for a less confusing experience in gdb.
Matthias Clasen [Sat, 18 Apr 2020 18:59:52 +0000 (14:59 -0400)]
docs: Mention focus adjustments in the migration guide
Matthias Clasen [Sat, 18 Apr 2020 18:55:41 +0000 (14:55 -0400)]
Drop gtk_container_set_focus_[hv]adjustment
This functionality should be provided by scrollables, see
for example by the recently added GtkViewport:scroll-to-focus.
Matthias Clasen [Sat, 18 Apr 2020 18:52:50 +0000 (14:52 -0400)]
tests: Stop using focus adjustments
Set scroll-to-focus instead, in testgtk.
Matthias Clasen [Sat, 18 Apr 2020 18:45:29 +0000 (14:45 -0400)]
flowbox: Stop setting focus adjustments
Matthias Clasen [Fri, 17 Apr 2020 02:47:37 +0000 (22:47 -0400)]
inspector: Use the new scroll-to-focus
Matthias Clasen [Thu, 16 Apr 2020 21:24:04 +0000 (17:24 -0400)]
scrolledwindow: Stop setting focus adjustments
Stop setting focus adjustments on the automatically
generated viewport.
Matthias Clasen [Thu, 16 Apr 2020 21:23:48 +0000 (17:23 -0400)]
Add a test for scroll-to-focus
Matthias Clasen [Thu, 16 Apr 2020 21:22:54 +0000 (17:22 -0400)]
viewport: Add GtkViewport:scroll-to-focus
And implement this property by listening for focus
changes, and updating the adjustments. This is a
replacement for setting focus adjustments on containers.
Nelson Benítez León [Sat, 18 Apr 2020 18:24:53 +0000 (14:24 -0400)]
GtkPlacesSidebar: avoid location clicks to grab focus
Sibebar location rows should not grab focus on click.
Fixes filechooser issue #1469
Matthias Clasen [Sat, 18 Apr 2020 18:39:01 +0000 (18:39 +0000)]
Merge branch 'css-docs' into 'master'
Shorten CSS docs
See merge request GNOME/gtk!1712
Matthias Clasen [Sat, 18 Apr 2020 06:25:23 +0000 (02:25 -0400)]
Shorten CSS docs
Fold the two CSS chapters into one, make more compact
tables of selectors and properties, and stop explaining
general CSS syntax.
Matthias Clasen [Thu, 16 Apr 2020 21:11:06 +0000 (17:11 -0400)]
widget-factory: Make color swatches non-focusable
Matthias Clasen [Thu, 16 Apr 2020 21:08:31 +0000 (17:08 -0400)]
colorchooser: Fix a crash
Don't crash when we start removing custom colors
that happen to be currently selected.
Matthias Clasen [Thu, 16 Apr 2020 19:46:27 +0000 (15:46 -0400)]
emojichooser: Drop focus adjustment setting
It is not needed here, we are now scrolling
differently.
Matthias Clasen [Sat, 18 Apr 2020 00:08:21 +0000 (20:08 -0400)]
filechooser: Cosmetic doc changes
Matthias Clasen [Sat, 18 Apr 2020 00:05:04 +0000 (20:05 -0400)]
drawingarea: Cosmetic docs fix
Matthias Clasen [Fri, 17 Apr 2020 23:57:15 +0000 (19:57 -0400)]
NEWS: More updates
Matthias Clasen [Fri, 17 Apr 2020 23:34:15 +0000 (23:34 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
Closes #1899 and #2627
See merge request GNOME/gtk!1709
Emmanuele Bassi [Fri, 17 Apr 2020 23:28:18 +0000 (23:28 +0000)]
Merge branch 'ebassi/for-master' into 'master'
cups: Disable deprecation warnings
See merge request GNOME/gtk!1710
Matthias Clasen [Fri, 17 Apr 2020 21:50:18 +0000 (17:50 -0400)]
migration docs: Updates
Mention shadow type, relief, aspect frame.
Emmanuele Bassi [Fri, 17 Apr 2020 22:33:20 +0000 (23:33 +0100)]
cups: Disable deprecation warnings
It seems newer releases of CUPS removed the ability to disable
deprecation warnings by defining a pre-processor symbol, so we
have to resort to the usual begin/end ignore deprecation pragmas
to avoid a ton of deprecation warnings.
Emmanuele Bassi [Fri, 17 Apr 2020 22:11:28 +0000 (22:11 +0000)]
Merge branch 'for-master' into 'master'
For master
See merge request GNOME/gtk!1708
Matthias Clasen [Fri, 17 Apr 2020 21:37:52 +0000 (17:37 -0400)]
aspectframe: Modernize
Make GtkAspectFrame not derive from GtkFrame anymore,
since frames now always draw, well, a frame. Also,
add proper setters for the properties of GtkAspectFrame.
Update our sole user.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/2627
Emmanuele Bassi [Fri, 17 Apr 2020 21:32:37 +0000 (22:32 +0100)]
Reconcile documentation with declaration and definition
The arguments name in the documentation must match declaration and
definition, or gtk-doc and g-ir-scanner will get very cross at us.
Emmanuele Bassi [Fri, 17 Apr 2020 21:23:32 +0000 (22:23 +0100)]
Copy axes when rewriting events
Matthias Clasen [Fri, 17 Apr 2020 20:13:01 +0000 (16:13 -0400)]
Adwaita: Add focus to expander
We were not drawing a focus indication at all for
expanders. Bring it back. Also, make the color plane
focus snug.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/1899
Matthias Clasen [Fri, 17 Apr 2020 19:43:18 +0000 (15:43 -0400)]
nodeeditor: Don't set has-focus
That is now a readonly property. Set focus-widget
on the toplevel instead.
Matthias Clasen [Fri, 17 Apr 2020 19:27:02 +0000 (19:27 +0000)]
Merge branch 'menu-section-title' into 'master'
popovermenu: Reinstate section title handling
See merge request GNOME/gtk!1707
Matthias Clasen [Fri, 17 Apr 2020 18:17:32 +0000 (18:17 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
gsk: Fall back to cairo if compiling shaders fails
See merge request GNOME/gtk!1706
Matthias Clasen [Fri, 17 Apr 2020 17:53:56 +0000 (13:53 -0400)]
popovermenu: Reinstate section title handling
We were creating a hbox with separators around the label,
but forgot to arrange sizing to prevent the separators from
shrinking into nothingness.
Matthias Clasen [Fri, 17 Apr 2020 16:35:37 +0000 (12:35 -0400)]
gsk: Fall back to cairo if compiling shaders fails
There was already some fallback in place here, but
in other places we were just asserting.
Matthias Clasen [Fri, 17 Apr 2020 17:41:08 +0000 (17:41 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
gsk: Fall back to cairo if compiling shaders fails
See merge request GNOME/gtk!1705
Matthias Clasen [Fri, 17 Apr 2020 17:29:56 +0000 (13:29 -0400)]
widget-factory: Add a menu section title
If you can't see it, you can't theme it.
Matthias Clasen [Fri, 17 Apr 2020 16:23:29 +0000 (16:23 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!1703
Matthias Clasen [Fri, 17 Apr 2020 15:06:16 +0000 (11:06 -0400)]
reftests: Stop using shadow-type
Matthias Clasen [Fri, 17 Apr 2020 06:15:14 +0000 (02:15 -0400)]
calendar: Fix focus keynav
This broke when the calendar was broken into widgets.
Matthias Clasen [Fri, 17 Apr 2020 04:32:29 +0000 (00:32 -0400)]
Drop GtkReliefStyle
We are not using this enum anymore.
Matthias Clasen [Fri, 17 Apr 2020 04:31:50 +0000 (00:31 -0400)]
menubutton: Drop relief
We are only using this as a boolean, so change it
to a boolean property named has-frame.
Matthias Clasen [Fri, 17 Apr 2020 04:20:09 +0000 (00:20 -0400)]
button: Drop relief
We are only using this as a boolean, so change it
to a boolean property named has-frame.
Matthias Clasen [Fri, 17 Apr 2020 03:59:23 +0000 (23:59 -0400)]
Drop GtkShadowType
We are not using this enum anymore.
Matthias Clasen [Fri, 17 Apr 2020 03:58:01 +0000 (23:58 -0400)]
viewport: Drop shadow-type
The viewport draws a frame at the same place as
the scrolled window, so there is really no need
to have that ability in both. Just drop the frame
from viewports.
Matthias Clasen [Fri, 17 Apr 2020 03:48:15 +0000 (23:48 -0400)]
frame: Drop shadow-type
Frames that don't draw frames are not very useful,
so just drop the shadow-type property.
Matthias Clasen [Fri, 17 Apr 2020 05:00:15 +0000 (01:00 -0400)]
treeviewcolumn: Stop using a frame
There is no desire to draw a frame here, so don't use a GtkFrame.
Matthias Clasen [Fri, 17 Apr 2020 03:25:06 +0000 (23:25 -0400)]
scrolledwindow: Drop shadow-type
We were only using this as a boolean, so change it
to a boolean property named has-frame.
Matthias Clasen [Fri, 17 Apr 2020 03:26:35 +0000 (23:26 -0400)]
scrolledwindow: Document the .frame style class
Timm Bäder [Fri, 17 Apr 2020 14:43:17 +0000 (16:43 +0200)]
Revert "modelbutton: Emit ::clicked() before closing the popover"
This reverts commit
57f913b7533b3b27ecd17ed7629e2b473e89bcbd.
Matthias Clasen [Fri, 17 Apr 2020 14:12:20 +0000 (14:12 +0000)]
Merge branch 'assorted-menu-fixes' into 'master'
Assorted menu fixes
See merge request GNOME/gtk!1704
Timm Bäder [Fri, 17 Apr 2020 06:14:34 +0000 (08:14 +0200)]
snapshot: Avoid a save/restore pair if we can
Timm Bäder [Fri, 17 Apr 2020 05:37:22 +0000 (07:37 +0200)]
label: Ignore setting attrs from NULL to NULL
Timm Bäder [Fri, 17 Apr 2020 05:27:21 +0000 (07:27 +0200)]
text: unconditionally unref attr list
pango_attr_list_unref() works on NULL
Timm Bäder [Fri, 17 Apr 2020 05:23:15 +0000 (07:23 +0200)]
text: Avoid creating a PangoAttrList we don't need
It's going to be empty, unless we have preedit_attrs
Timm Bäder [Fri, 17 Apr 2020 04:55:00 +0000 (06:55 +0200)]
meson: Use summary()
Instead of doing our own. Bumps the dependency to 0.53 though.
Timm Bäder [Fri, 17 Apr 2020 04:53:23 +0000 (06:53 +0200)]
meson: Trivial formattting
Timm Bäder [Tue, 14 Apr 2020 13:22:52 +0000 (15:22 +0200)]
label: Redraw when text attrs are affected by css change
GtkWidget doesn't do it automatically and probably shouldn't
Timm Bäder [Tue, 14 Apr 2020 09:11:23 +0000 (11:11 +0200)]
label: Don't create an unnecessary attribute list
Timm Bäder [Tue, 14 Apr 2020 09:11:08 +0000 (11:11 +0200)]
label: Only parse mnemonic attributes if we need to
Timm Bäder [Tue, 14 Apr 2020 08:53:48 +0000 (10:53 +0200)]
label: Ignore AFFECTS_ATTRS css changes if we can
It's only interesting if we either already have attributes, or the new
style adds some.
Timm Bäder [Tue, 14 Apr 2020 07:20:00 +0000 (09:20 +0200)]
label: Inline function into only caller
Timm Bäder [Mon, 13 Apr 2020 06:57:36 +0000 (08:57 +0200)]
label: Remove some unused quarks
Timm Bäder [Mon, 13 Apr 2020 06:56:33 +0000 (08:56 +0200)]
label: Remove priv pointer
Timm Bäder [Mon, 13 Apr 2020 06:23:32 +0000 (08:23 +0200)]
label: Stop connecting to notify::gtk-enable-accels
Leftover from when GtkAccelLabel was a GtkLabel subclass. GtkAccelLabel
connects to this itself these days though.
Timm Bäder [Sun, 12 Apr 2020 17:54:20 +0000 (19:54 +0200)]
label: Set underline text and markup in one step
Try to unify the way we parse the mnemonic character
Timm Bäder [Sun, 12 Apr 2020 12:54:54 +0000 (14:54 +0200)]
label: Fold set_pattern_internal into only caller
Timm Bäder [Sun, 12 Apr 2020 09:17:46 +0000 (11:17 +0200)]
adwaita: don't extent %link in linkbuttons
We already do that for the label inside the button.
Timm Bäder [Sun, 12 Apr 2020 09:05:28 +0000 (11:05 +0200)]
label: Remove GtkLabel:track-visited-links
Always track visited state of links. This way all visited links in all
labels look the same. Whether the theme wants to style :visited is the
theme's business.